-
Notifications
You must be signed in to change notification settings - Fork 880
Replace legacy DeleteItem params #4364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aanton-git
wants to merge
11
commits into
aws:development
Choose a base branch
from
aanton-git:feature/replace-legacy-parameter-DeleteItem
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8547937
Initial commit
aanton-git 315b4c8
Add Unit test
aanton-git 8abf251
Add change log file
aanton-git 91a2ff1
Fix comments
aanton-git f92b8eb
Small update
aanton-git 2e4225a
Add tests
aanton-git c33068d
Update unit tests
aanton-git f258868
Update change log file
aanton-git 1c8758c
add integration test
aanton-git a01db28
Resolve Copilot comments
aanton-git a3a2eb0
Merge branch 'development' into feature/replace-legacy-parameter-Dele…
aanton-git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
generator/.DevConfigs/264e45e8-60ef-4e07-8f70-7fb4dc554187.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "services": [ | ||
| { | ||
| "serviceName": "DynamoDBv2", | ||
| "type": "patch", | ||
| "changeLogMessages": [ | ||
| "Replace legacy parameter Expected with ConditionExpression in DeleteItem and DeleteItemAsync flow" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...rc/Services/DynamoDBv2/Custom/DocumentModel/InternalDeleteItemDocumentOperationRequest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| using Amazon.DynamoDBv2.Model; | ||
| using System.Collections.Generic; | ||
|
aanton-git marked this conversation as resolved.
|
||
|
|
||
| namespace Amazon.DynamoDBv2.DocumentModel | ||
| { | ||
| /// <summary> | ||
| /// Represents an internal request to delete an item from a DynamoDB table using the Document Model. | ||
| /// This class introduces a modern expression-based API that replaces legacy parameter-based approaches. | ||
| /// Legacy parameters such as Expected are not supported. | ||
| /// Use ConditionalExpression instead. | ||
| /// </summary> | ||
| internal class InternalDeleteItemDocumentOperationRequest : BaseDeleteItemDocumentOperationRequest | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the key identifying the item in the table. | ||
| /// </summary> | ||
| internal Dictionary<string, AttributeValue> Key { get; set; } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New public API is being added/changed in this PR (e.g., introducing
BaseDeleteItemDocumentOperationRequestand changingDeleteItemDocumentOperationRequest's base type). Per DevConfig guidance, this should likely be aminorbump rather thanpatchto reflect the public surface area change.