Open
Conversation
…button to quickly generate a new seed
…d add the Seed and Settings to the spoiler log. Also, make the spoiler log named and pathed identically to the rom
|
|
||
| private string SpoilerLogFilename() | ||
| { | ||
| return saveROM.FileName.Replace(".z64", ".txt"); |
Contributor
There was a problem hiding this comment.
I think the filename should still say SpoilerLog somewhere.
| { | ||
| tSeed.Text = seedRng.Next().ToString(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Unpleasant mixture of tabs and spaces here and elsewhere in this pull request.
ProbablyButter
pushed a commit
to ProbablyButter/mm-rando
that referenced
this pull request
May 17, 2019
Fix outputted files to all be in the same user-selected directory.
ProbablyButter
pushed a commit
to ProbablyButter/mm-rando
that referenced
this pull request
May 17, 2019
Fix outputted files to all be in the same user-selected directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize there are benefits to having as part of the settings string, including easier sharing and bug reporting. However, I think for most cases, it is better to be separated. This PR makes the following changes:
Benefits: