fix(Core/Battlegrounds): Remove siege damage buffs on node assault in IoC

[Nyeriah]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

The Oil Refinery (SPELL_OIL_REFINERY 68719) and Quarry (SPELL_QUARRY 68720) siege damage buffs in Isle of Conquest are only removed when the opposing team fully captures the node. They should be removed as soon as the node is assaulted (contested).

The fix adds Refinery and Quarry handling to HandleContestedNodes(), which already handles similar immediate-effect logic for the Hangar (disabling the gunship on assault). When either node is assaulted, RemoveAuraOnTeam() strips the buff from the previously controlling team immediately.

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

• AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Claude Opus 4.6 was used.

Issues Addressed:

• Closes [Isle of Conquest] Siege damage buffs behaviour #23676

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick).

Video evidence from the issue: https://www.youtube.com/watch?v=h6zD1TsScb0

• 4:28 — Horde assaults Quarry, Alliance loses the buff immediately.

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. Start an Isle of Conquest battleground with players on both factions.
2. Have one faction capture Oil Refinery or Quarry and confirm the siege damage buff is applied.
3. Have the opposing faction assault (click the banner of) the captured node.
4. Verify the buff is removed from the original controlling team immediately on assault, not after the 60-second capture timer completes.

Known Issues and TODO List:

• Verify no edge cases with rapid re-assault (node flipping back and forth quickly).

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Copilot]

Pull request overview

Updates Isle of Conquest node-assault handling so the Quarry/Oil Refinery siege-damage auras are removed immediately when a node becomes contested (assaulted), matching expected in-game behavior.

Changes:

• Add contested-node handling for Refinery and Quarry in HandleContestedNodes()
• Remove the corresponding team aura immediately on assault via RemoveAuraOnTeam()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.