fix(Scripts/Northrend): improve EoE encounter visuals#25258
fix(Scripts/Northrend): improve EoE encounter visuals#25258sogladev wants to merge 3 commits intoazerothcore:masterfrom
Conversation
Update and fix teleport visual spell Set Npc flags of Hover Disk
There was a problem hiding this comment.
Pull request overview
Updates Eye of Eternity (Malygos) encounter scripting and DB data to improve spawn/teleport visuals and make Hover Disks behave correctly for players during Phase 2.
Changes:
- Updated the teleport visual spell ID used by EoE trash spawns.
- Deferred teleport visual casting via scheduler for Nexus Lords and Scions; adjusted Hover Disk / Wyrmrest Skytalon animation tier and disk interaction state on dismount.
- Added a pending world DB update to adjust Hover Disk creature_template faction/npcflag/unit_flags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/server/scripts/Northrend/Nexus/EyeOfEternity/eye_of_eternity.h |
Switches the spell ID used for the teleport visual. |
src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp |
Schedules teleport visuals on spawn; tweaks vehicle visuals and Hover Disk state after passengers disembark. |
data/sql/updates/pending_db_world/rev_1774496999317065090.sql |
Updates Hover Disk template flags to support intended interaction/visibility behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,2 @@ | |||
| -- | |||
| UPDATE `creature_template` SET `faction` = 14, `npcflag` = 16777216, `unit_flags` = 33554432 WHERE (`entry` = 30248); | |||
There was a problem hiding this comment.
This UPDATE overwrites creature_template.unit_flags with only UNIT_FLAG_NOT_SELECTABLE (33554432). In the base world DB, entry 30248 currently has unit_flags = 2 (UNIT_FLAG_NON_ATTACKABLE), so this change would drop that bit and potentially make the disk damageable (e.g., by AoE) while it is still hostile. Consider preserving existing bits (e.g., unit_flags = unit_flags | 33554432) or explicitly setting the combined value (e.g., include UNIT_FLAG_NON_ATTACKABLE) if the disk must remain unattackable.
| UPDATE `creature_template` SET `faction` = 14, `npcflag` = 16777216, `unit_flags` = 33554432 WHERE (`entry` = 30248); | |
| UPDATE `creature_template` SET `faction` = 14, `npcflag` = 16777216, `unit_flags` = `unit_flags` | 33554432 WHERE (`entry` = 30248); |
Changes Proposed:
This PR proposes changes to:
Update and fix the teleport visual spell
Set NPC flags of Hover Disk. Hover Disk spawns as an enemy + unselectable.
AI-assisted Pull Requests
Important
While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.
Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.