refactor(Core/Scripts): move Outland gossip handlers to database#25274
Merged
Nyeriah merged 1 commit intoazerothcore:masterfrom Mar 28, 2026
Merged
refactor(Core/Scripts): move Outland gossip handlers to database#25274Nyeriah merged 1 commit intoazerothcore:masterfrom
Nyeriah merged 1 commit intoazerothcore:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves several simple Outland NPC gossip behaviors out of C++ scripts into DB-driven conditions and SmartAI, reducing hardcoded gossip handlers and aligning with the ongoing effort to data-drive gossip logic (per #25207).
Changes:
- Removed C++ gossip scripts for Shattrath flask vendors, Zephyr teleport, Drake Dealer Hurlunk, and Flanis/Kagrosh item delivery.
- Added DB
conditionsto gate gossip options/text by reputation, quest state, and item ownership. - Added SmartAI entries to perform teleport/item delivery actions on gossip selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/server/scripts/Outland/zone_shattrath_city.cpp | Removes C++ gossip handlers for flask vendors and Zephyr and unregisters their script classes. |
| src/server/scripts/Outland/zone_shadowmoon_valley.cpp | Removes C++ gossip handlers for Drake Dealer Hurlunk and Flanis/Kagrosh and unregisters their script classes. |
| data/sql/updates/pending_db_world/rev_1774580000_gossip_outland.sql | Introduces DB conditions + SmartAI equivalents for the removed gossip handlers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c177c99 to
19c776d
Compare
Kitzunu
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed
Move simple gossip handlers from C++ scripts to database conditions + SmartAI for 5 Outland NPCs:
How Has This Been Tested?
Requires in-game testing:
Issues Addressed
Continuation of #25207 — moving hardcoded gossip handlers to database handling.
AI Usage Disclosure
Generated with Claude Code (Claude Opus 4.6)