Skip to content

refactor(Core/Scripts): move Outland gossip handlers to database#25274

Merged
Nyeriah merged 1 commit intoazerothcore:masterfrom
Nyeriah:outland-gossip-to-db
Mar 28, 2026
Merged

refactor(Core/Scripts): move Outland gossip handlers to database#25274
Nyeriah merged 1 commit intoazerothcore:masterfrom
Nyeriah:outland-gossip-to-db

Conversation

@Nyeriah
Copy link
Copy Markdown
Member

@Nyeriah Nyeriah commented Mar 28, 2026

Changes Proposed

Move simple gossip handlers from C++ scripts to database conditions + SmartAI for 5 Outland NPCs:

  • Haldor the Compulsive (23484) & Arcanist Xorith (23483) — Shattrath flask vendors: reputation-gated vendor (Exalted with 3 factions)
  • Zephyr (25967) — Reputation-gated teleport to Caverns of Time (Revered+ Keepers of Time)
  • Drake Dealer Hurlunk (23489) — Reputation-gated vendor (Exalted with Netherwing)
  • Flanis Swiftwing (21727) & Kagrosh (21725) — Quest-gated item delivery

How Has This Been Tested?

Requires in-game testing:

  • Flask vendors show vendor option only when exalted with all 3 required factions, rejection text otherwise
  • Zephyr shows teleport option only when Revered+ with Keepers of Time, casts teleport spell on select
  • Drake Dealer Hurlunk shows vendor option only when Exalted with Netherwing
  • Flanis gives pack only when quest 10583 is incomplete and player doesn't have item
  • Kagrosh gives pack only when quest 10601 is incomplete and player doesn't have item

Issues Addressed

Continuation of #25207 — moving hardcoded gossip handlers to database handling.

AI Usage Disclosure

Generated with Claude Code (Claude Opus 4.6)

Copilot AI review requested due to automatic review settings March 28, 2026 00:27
@github-actions github-actions bot added DB related to the SQL database Script Refers to C++ Scripts for the Core file-cpp Used to trigger the matrix build labels Mar 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves several simple Outland NPC gossip behaviors out of C++ scripts into DB-driven conditions and SmartAI, reducing hardcoded gossip handlers and aligning with the ongoing effort to data-drive gossip logic (per #25207).

Changes:

  • Removed C++ gossip scripts for Shattrath flask vendors, Zephyr teleport, Drake Dealer Hurlunk, and Flanis/Kagrosh item delivery.
  • Added DB conditions to gate gossip options/text by reputation, quest state, and item ownership.
  • Added SmartAI entries to perform teleport/item delivery actions on gossip selection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/server/scripts/Outland/zone_shattrath_city.cpp Removes C++ gossip handlers for flask vendors and Zephyr and unregisters their script classes.
src/server/scripts/Outland/zone_shadowmoon_valley.cpp Removes C++ gossip handlers for Drake Dealer Hurlunk and Flanis/Kagrosh and unregisters their script classes.
data/sql/updates/pending_db_world/rev_1774580000_gossip_outland.sql Introduces DB conditions + SmartAI equivalents for the removed gossip handlers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Nyeriah Nyeriah force-pushed the outland-gossip-to-db branch from c177c99 to 19c776d Compare March 28, 2026 11:01
@Nyeriah Nyeriah merged commit c10e19e into azerothcore:master Mar 28, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB related to the SQL database file-cpp Used to trigger the matrix build Script Refers to C++ Scripts for the Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants