fix(DB/Loot): Fix incorrect loot pool structure for 9 Naxxramas 25-man bosses#25276
Open
espkk wants to merge 1 commit intoazerothcore:masterfrom
Open
fix(DB/Loot): Fix incorrect loot pool structure for 9 Naxxramas 25-man bosses#25276espkk wants to merge 1 commit intoazerothcore:masterfrom
espkk wants to merge 1 commit intoazerothcore:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the World database loot definitions for several Naxxramas 25-man bosses to match expected retail WotLK “multi-pool” behavior, separating boss-specific drops and shared drops into distinct loot groups.
Changes:
- Updates
creature_loot_templatereference rows for 9 bosses to roll their reference table once (MinCount/MaxCountset to1) instead of multiple times. - Re-structures each boss’s
reference_loot_templateby splitting the previously singleGroupIdinto multipleGroupIdpools (e.g., 5+5+5+9 or 5+4+5+9).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Fixes incorrect loot pool structure for 9 Naxxramas 25-man bosses.
Wowhead/wowdb 25-man drop data shows a clear bimodal distribution for all 24-item bosses:
This is only possible if boss items and shared items are in separate pools of different sizes. A single flat pool of 24 with 4 picks gives 16.7% uniform.
chromiecraft/chromiecraft#9131 provided kill-by-kill co-occurrence data for Anub'Rekhan, revealing an asymmetric 5+4+5+9 structure. For all other bosses 5+5+5+9 pools are used:
Effectively, this increases the drop rate of non-shared items and decreases that of shared items.
AI-assisted Pull Requests
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
cs_debug.cppto increase iteration limit from 100 to 10000 (100 is too low for statistical inference)Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.