Conversation
jacksga
force-pushed
the
feat/mirrored-package-identification
branch
from
3371048 to
5630c41
Compare
|
Hey @Regenhardt and @FroggieFrog, |
|
Hey, could you please provide me with some form of reaction or feedback regarding this? |
|
Hi yes sorry, I definitely like this, just want to combine it with something else that also needs to modify the DB schema. |
|
@Regenhardt Do you still have further plans on this? |
|
@Regenhardt could you please take another look at this one ? |
|
Hey @Regenhardt is there any chance we could get this wrapped up and done this year as a christmas present for everyone trying to identify mirrored packages for cleanup? |
Regenhardt
left a comment
Regenhardt
left a comment
There was a problem hiding this comment.
Would actually prefer sometihng like UpstreamSource instead of MirroredFrom, not sure why though so I'm open for arguments here.
|
Maybe we can indeed get this wrappped up for christmas :) Also rebase (or merge main) please. |
For me upstream in a general software development perspective is more missleading than mirror, therefore I opted for MirroredFrom. Would also be up for a mix (MirrorSource) but in perspective of getting it done before christmas I'd choose whatever your last word is :D When you decided on the name for the property I will rebase, change the name, fix the domain and usings and create new migrations. |
|
Happy new year! Anyway, how about |
|
Happy new year to you too, I'm sorry to hear that, hope you haven't lost anything important except from time and nerves. When reading your comment I figured well yeah, they are cached, so why not If you don't like the idea I will just use Being back from vacation I do now have the time to finish everything after we sorted the naming thing. |
|
Welcome back, hope you had a nice vacation. Thanks, yes it was mostly the time, I fortunately had mostly just windows itself on there. I think |
jacksga
force-pushed
the
feat/mirrored-package-identification
branch
from
d354537 to
5e2b96b
Compare
Regenhardt
left a comment
Regenhardt
left a comment
There was a problem hiding this comment.
Ok this should be the last time I send this back, thanks a lot for staying with me on this.
| /// <param name="cancellationToken"></param> | ||
| /// <returns>The result of the attempted indexing operation.</returns> | ||
| Task<PackageIndexingResult> IndexAsync(Stream stream, CancellationToken cancellationToken); | ||
| Task<PackageIndexingResult> IndexAsync(Stream stream, string cacheFeedUrl = null, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
Please create an overload without the new parameter so we can release this without a breaking change to the API.
|
|
||
| public string GetServiceIndexUrl() | ||
| { | ||
| return "https://disabled-upstream-client.example.org"; |
There was a problem hiding this comment.
Actually return null here, as there is no upstream.
|
@jacksga great work and I appreciate your patience on this Could you implement @Regenhardt's suggestions so this finally can be merged ? |
…ple.org based domain, cleanup of usings in V3UpstreamClient
jacksga
force-pushed
the
feat/mirrored-package-identification
branch
from
5e2b96b to
b85a525
Compare
4 participants
Summary of the changes
Addresses #187