Add support for embedded license file#76
Conversation
|
Since we need a migration anyway, can you add a "Deprecated" boolean to the package as well? We can add it to the rest of the application later, but it requires a migration too and I feel like it's always nice to keep those to a minimum. It was requested in loic-sharma#723. |
|
We could keep the commits separate instead of squashing on merge too if anyone thinks this might overload the feature, that might keep the history clearer. |
|
I would vote for separate PRs because those are separate features. |
|
Don't like to jump in on your project. I'm glad you liked my code and want to pull in some of the changes. |
|
This PR is stale because it has been open for 90 days with no activity. Remove the stale label, comment, or this will be closed in 10 days. |
This PR adds support for downloading an embedded license file and is based on this PR by @rbdavison.
current situation
If a package has an embedded license file, the link on the package details page is https://aka.ms/deprecateLicenseUrl which states:
So a user has to do multiple manual steps to download the license.
situation after this PR
The package details page has a direct link to the license.
So a user has to do one click to download the license.
Todo:
more information:
Testdata I used/created: testdata.zip