Replace Newtonsoft.Json by System.Text.Json#86
Draft
FroggieFrog wants to merge 3 commits intobagetter:mainfrom
Draft
Replace Newtonsoft.Json by System.Text.Json#86FroggieFrog wants to merge 3 commits intobagetter:mainfrom
Newtonsoft.Json by System.Text.Json#86FroggieFrog wants to merge 3 commits intobagetter:mainfrom
Conversation
|
Looks like BaGetter.Tests is the only project that references Newtonsoft.Json, can you remove it from that too? |
|
Wait how is it used in .Core when Core doesn't even reference the lib? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update 2023-03-05
At the moment it is not possible to remove
Newtonsoft.Json, because upstream packages refeence it:This PR replaces
Newtonsoft.JsonwithSystem.Text.Json.