[Automated] Sync master after 1.19.0 release#793
Conversation
ballerina-cicd-bot
requested review from
RDPerera,
niveathika and
shafreenAnfar
as code owners
📝 WalkthroughWalkthroughThis PR updates dependency paths and versions across Ballerina configuration files. SNAPSHOT artifact references are converted to release versions in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ballerina/Ballerina.toml`:
- Around line 19-22: The artifact paths in the TOML are pinned to 1.19.0 (the
two entries containing "sql-native-1.19.0.jar" and "sql-test-utils-1.19.0.jar")
which will fail on this branch; update those path values to match the branch
snapshot (e.g., replace "1.19.0" with "1.19.1-SNAPSHOT") or switch to a
non-versioned/globbed artifact name used by your Gradle build so the expected
jars exist in build/libs during CI.
In `@ballerina/CompilerPlugin.toml`:
- Line 6: The path value in CompilerPlugin.toml currently points to
sql-compiler-plugin-1.19.0.jar which mismatches the project version
1.19.1-SNAPSHOT; update the path string on the line with path =
"../compiler-plugin/build/libs/sql-compiler-plugin-1.19.0.jar" to reference the
actual build artifact (e.g., sql-compiler-plugin-1.19.1-SNAPSHOT.jar) or use a
stable selector (such as the wildcarded/shorthand artifact name produced by the
build) so the compiler plugin resolves the local ../compiler-plugin/build/libs
output correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 54ee6d52-8052-4026-94b0-6951677c1412
📒 Files selected for processing (5)
ballerina/Ballerina.tomlballerina/CompilerPlugin.tomlballerina/Dependencies.tomlchangelog.mdgradle.properties
| path = "../native/build/libs/sql-native-1.19.0.jar" | ||
|
|
||
| [[platform.java21.dependency]] | ||
| path = "../test-utils/build/libs/sql-test-utils-1.19.0-SNAPSHOT.jar" | ||
| path = "../test-utils/build/libs/sql-test-utils-1.19.0.jar" |
There was a problem hiding this comment.
Artifact path version mismatch can break snapshot builds
On Line 19 and Line 22, paths are pinned to 1.19.0 jars, but this branch is already on 1.19.1-SNAPSHOT. With default Gradle jar naming, these files may not exist in build/libs during normal master builds.
Proposed fix
-path = "../native/build/libs/sql-native-1.19.0.jar"
+path = "../native/build/libs/sql-native-1.19.1-SNAPSHOT.jar"
...
-path = "../test-utils/build/libs/sql-test-utils-1.19.0.jar"
+path = "../test-utils/build/libs/sql-test-utils-1.19.1-SNAPSHOT.jar"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| path = "../native/build/libs/sql-native-1.19.0.jar" | |
| [[platform.java21.dependency]] | |
| path = "../test-utils/build/libs/sql-test-utils-1.19.0-SNAPSHOT.jar" | |
| path = "../test-utils/build/libs/sql-test-utils-1.19.0.jar" | |
| path = "../native/build/libs/sql-native-1.19.1-SNAPSHOT.jar" | |
| [[platform.java21.dependency]] | |
| path = "../test-utils/build/libs/sql-test-utils-1.19.1-SNAPSHOT.jar" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ballerina/Ballerina.toml` around lines 19 - 22, The artifact paths in the
TOML are pinned to 1.19.0 (the two entries containing "sql-native-1.19.0.jar"
and "sql-test-utils-1.19.0.jar") which will fail on this branch; update those
path values to match the branch snapshot (e.g., replace "1.19.0" with
"1.19.1-SNAPSHOT") or switch to a non-versioned/globbed artifact name used by
your Gradle build so the expected jars exist in build/libs during CI.
|
|
||
| [[dependency]] | ||
| path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.19.0-SNAPSHOT.jar" | ||
| path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.19.0.jar" |
There was a problem hiding this comment.
Compiler plugin jar path likely mismatched with snapshot artifact name
Line 6 references sql-compiler-plugin-1.19.0.jar, but current project version is 1.19.1-SNAPSHOT; this can fail when resolving local build outputs from ../compiler-plugin/build/libs.
Proposed fix
-path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.19.0.jar"
+path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.19.1-SNAPSHOT.jar"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.19.0.jar" | |
| path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.19.1-SNAPSHOT.jar" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ballerina/CompilerPlugin.toml` at line 6, The path value in
CompilerPlugin.toml currently points to sql-compiler-plugin-1.19.0.jar which
mismatches the project version 1.19.1-SNAPSHOT; update the path string on the
line with path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.19.0.jar"
to reference the actual build artifact (e.g.,
sql-compiler-plugin-1.19.1-SNAPSHOT.jar) or use a stable selector (such as the
wildcarded/shorthand artifact name produced by the build) so the compiler plugin
resolves the local ../compiler-plugin/build/libs output correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
=========================================
Coverage 78.36% 78.36%
Complexity 109 109
=========================================
Files 44 44
Lines 3962 3962
Branches 634 634
=========================================
Hits 3105 3105
Misses 594 594
Partials 263 263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Sync master after 1.19.0 release
Summary
This pull request synchronizes the master branch with changes from the 1.19.0 release cycle. The changes focus on dependency management, version updates, and release documentation.
Changes
Dependency Resolution: Updated references to released build artifacts in configuration files by replacing SNAPSHOT versions with corresponding release versions in
Ballerina.tomlandCompilerPlugin.toml.Version Management: Incremented the project version from 1.19.0-SNAPSHOT to 1.19.1-SNAPSHOT in
gradle.propertiesto reflect the next development cycle. Updated dependency versions for theobserveandurllibraries to maintain compatibility with the latest compatible versions.Dependency Compatibility: Adjusted dependency versions in
Dependencies.tomlto align with the release requirements.Release Documentation: Added changelog entry for version 1.19.0 documenting the addition of observability metrics for SQL connection pools.
All changes are configuration and metadata updates with minimal code review effort required. No changes to exported or public entity declarations were made.