Extend unit tests and fix decoding bug - #742
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increased coverage around the encoding/conversion paths and fixed one real decoding bug.
src/PhpImap/Mailbox.php:1965now always strips RFC2231 charset'lang' metadata and decodes the value, even when the filename is plain ASCII instead of percent-encoded. I added focused tests intests/unit/MailboxEncodingTest.php:11forconvertToUtf8,isUrlEncoded, and RFC2231 decoding, exposed the protected helper throughtests/unit/Fixtures/Mailbox.php:11, and extendedtests/unit/ LiveMailboxStringDecodingConvertingTest.php:22withwindows-1251andcp1252quoted-printable cases.