Make TestCoverage properly typed and self-documenting#1887
Draft
bartfeenstra wants to merge 5 commits into0.5.xfrom
Draft
Make TestCoverage properly typed and self-documenting#1887bartfeenstra wants to merge 5 commits into0.5.xfrom
TestCoverage properly typed and self-documenting#1887bartfeenstra wants to merge 5 commits into0.5.xfrom
Conversation
bartfeenstra
added
enhancement
bartfeenstra
commented
Aug 23, 2024
bartfeenstra
force-pushed
the
typed-coverage-test
branch
from
b80db01 to
83fe87c
Compare
bartfeenstra
commented
Aug 23, 2024
|
|
||
|
|
||
| @lru_cache | ||
| def get_coveragerc_ignore_modules() -> Sequence[Path]: |
Owner
Author
There was a problem hiding this comment.
Make this return importable strings
bartfeenstra
commented
Aug 23, 2024
| pass | ||
|
|
||
|
|
||
| class Method(Testable): |
Owner
Author
There was a problem hiding this comment.
What about properties?
bartfeenstra
commented
Aug 23, 2024
| ) | ||
|
|
||
|
|
||
| class MissingReason(Enum): |
Owner
Author
There was a problem hiding this comment.
Move the APIs to test_utils?
bartfeenstra
force-pushed
the
typed-coverage-test
branch
from
ef29fa7 to
4d5f64c
Compare
bartfeenstra
commented
Aug 24, 2024
| continue | ||
|
|
||
| yield imported_member | ||
| class Class(HasChildren[Method]): |
Owner
Author
There was a problem hiding this comment.
Make this add its own testable members
bartfeenstra
commented
Aug 24, 2024
|
|
||
|
|
||
| class _ModuleFunctionCoverageTester: | ||
| class Module(HasChildren[Union["Module", Class, Function]]): |
Owner
Author
There was a problem hiding this comment.
Make this add its own testable members
Owner
Author
There was a problem hiding this comment.
Add an internal method add_undefined_children()?
bartfeenstra
force-pushed
the
typed-coverage-test
branch
from
e4fa977 to
d59411a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do