Skip to content

Conversation

@Farukest
Copy link
Contributor

Summary

  • Move versioned dependencies from op-rbuilder's Cargo.toml to the workspace Cargo.toml
  • Update op-rbuilder to use workspace = true syntax for all dependencies
  • Update ctor version from 0.2 to 0.4.2

Changes

Added to workspace:

  • anyhow, tower, shellexpand, serde_yaml, moka, http, sha3, k256
  • nanoid, tar, rlimit, hyper, hyper-util, http-body-util
  • testcontainers, dirs-next, tempfile

op-rbuilder had hardcoded dependency versions while the rest of the workspace uses centralized versioning. This aligns op-rbuilder with the project's dependency management pattern.

Closes #469

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 14, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this - looks good, just needs a quick rebase

Move versioned dependencies from op-rbuilder's Cargo.toml to the
workspace Cargo.toml and update op-rbuilder to use workspace = true.

Added to workspace:
- anyhow, tower, shellexpand, serde_yaml, moka, http, sha3, k256
- nanoid, tar, rlimit, hyper, hyper-util, http-body-util
- testcontainers, dirs-next, tempfile

Updated in workspace:
- ctor: 0.2 -> 0.4.2

This ensures consistent dependency versions across the workspace.

Closes base#469
@Farukest Farukest force-pushed the chore/standardize-op-rbuilder-deps branch from 824d813 to b3bd0ed Compare January 15, 2026 09:34
@Farukest
Copy link
Contributor Author

Thanks for tackling this - looks good, just needs a quick rebase

Handled @refcell thank you.

@refcell refcell enabled auto-merge January 15, 2026 12:40
@refcell refcell added this pull request to the merge queue Jan 15, 2026
Merged via the queue into base:main with commit 6c10062 Jan 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(builder): Hoist Versioned Dependencies

3 participants