Skip to content

fix(geth): remove unused txpool variables and align comment #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danyalprout merged 1 commit into from
Oct 8, 2025
Merged

fix(geth): remove unused txpool variables and align comment #572

danyalprout merged 1 commit into from
Oct 8, 2025

Conversation

@sashass1315
Copy link
Contributor

@sashass1315 sashass1315 commented Oct 8, 2025

  • Remove unused txpool-related env vars from geth entrypoint
  • Update comment to reference only cache optimizations
  • No runtime behavior change; cleans up dead code and avoids confusion

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 8, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout merged commit b86b168 into base:main Oct 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danyalprout danyalprout danyalprout approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sashass1315 @cb-heimdall @danyalprout