Merged
Conversation
Rails 8.2 removed the `dom_id` method from the ActionText tag in rails/rails#51238, breaking Lexxy's override. Use `@template_object.dom_id` instead which works in all releases. (`@template_object` is the view context and always has access to `RecordIdentifier` helpers, including `dom_id`.) This is obviated by #484 but allows Rails 8.2 apps to not break before adopting the adapter setup.
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 9, 2025
Rails does post-upload variant processing using the same file upload in rails/rails#56327 Unrelated fix due to Rails bump: Pulls in basecamp/lexxy#493 to work around `dom_id` removal from ActionText tag in rails/rails#51238
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 9, 2025
Rails does post-upload variant processing using the same file upload in rails/rails#56327 Unrelated fix due to Rails bump: Pulls in basecamp/lexxy#493 to work around `dom_id` removal from ActionText tag in rails/rails#51238
jorgemanrubia
approved these changes
Dec 9, 2025
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 9, 2025
Rails does post-upload variant processing using the same file upload in rails/rails#56327 Unrelated fix due to Rails bump: Pulls in basecamp/lexxy#493 to work around `dom_id` removal from ActionText tag in rails/rails#51238
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 9, 2025
Rails does post-upload variant processing using the same file upload in rails/rails#56327 Unrelated Lexxy bump: Pulls in basecamp/lexxy#493 to work around `dom_id` removal from ActionText tag in rails/rails#51238
lonexw
pushed a commit
to lonexw/kanban
that referenced
this pull request
Dec 9, 2025
Rails does post-upload variant processing using the same file upload in rails/rails#56327 Unrelated Lexxy bump: Pulls in basecamp/lexxy#493 to work around `dom_id` removal from ActionText tag in rails/rails#51238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 8.2 removed the
dom_idmethod from the ActionText tag in rails/rails#51238, breaking Lexxy's override.Use
@template_object.dom_idinstead which works in all releases. (@template_objectis the view context and always has access toRecordIdentifierhelpers, includingdom_id.)This is obviated by #484 but allows Rails 8.2 apps to not break before adopting the adapter setup.