Fix prompt keyboard navigation inside tables

[yanfroes]

Fixes #677

Problem
When using @ mentions (or other prompts) inside a table cell, pressing arrow keys navigates between table cells instead of navigating the dropdown options.

Cause
Lexical's table plugin registers arrow key handlers at COMMAND_PRIORITY_HIGH during editor initialization. The prompt also registered its handlers at the same priority, but later—causing table handlers to intercept keyboard events first.

Solution
Changed prompt key handlers from COMMAND_PRIORITY_HIGH to COMMAND_PRIORITY_CRITICAL, ensuring they take precedence over table navigation when the prompt is open.

lexxy-fix-prompt-keyboard-navigation-inside-tables.mp4

[Copilot]

Pull request overview

This PR fixes keyboard navigation for prompt dropdowns (e.g., @ mentions) when used inside table cells by changing the priority of keyboard event handlers from COMMAND_PRIORITY_HIGH to COMMAND_PRIORITY_CRITICAL.

Changes:

• Updated keyboard command registration priorities in prompt.js from COMMAND_PRIORITY_HIGH to COMMAND_PRIORITY_CRITICAL for all key handlers (ENTER, TAB, SPACE, ARROW_UP, ARROW_DOWN)
• Imported COMMAND_PRIORITY_CRITICAL from Lexical
• Updated comments to reflect the new priority level

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[zoltanhosszu]

I like this, a simple solution, thank you @yanfroes!

@samuelpecher any feedback on this?

[samuelpecher]

LGTM; I wouldn't want to push the table handle commands down the priority list, so 👍

[samuelpecher]

This could do with a test to ensure we don't regress in the future if priorities are ever revised.

[yanfroes]

@zoltanhosszu @samuelpecher Just added the test! =)

[zoltanhosszu]

Looking solid! Let's ship it :) 🚀

[Copilot]

Pull request overview

Copilot reviewed 4 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

test/system/prompts_test.rb:114

• The assertions immediately after find_editor.send :arrow_down may be flaky because send_keys doesn’t flush Lexical updates, and the DOM/aria-selected state may not be updated by the time we re-query .lexxy-prompt-menu__item. Consider wrapping the post-keypress assertions in wait_until (e.g., wait until the second item becomes selected and the prompt is still open) so flush_lexical_updates runs before asserting.

    find_editor.send :arrow_down

    assert find_editor.open_prompt?, "Prompt closed after pressing arrow down. The table plugin intercepted the key event because prompt handlers are not using COMMAND_PRIORITY_CRITICAL."

    prompt_items = all(".lexxy-prompt-menu__item")
    refute prompt_items[0]["aria-selected"], "First item should not be selected after arrow down"
    assert prompt_items[1]["aria-selected"], "Second item should be selected after arrow down - prompt handled the arrow key"

test/system/prompts_test.rb:122

• Same as above for the :arrow_up path: after find_editor.send :arrow_up, the selection/aria-selected changes may not be reflected immediately across drivers/CI timing. Wrapping the re-query + assertions in wait_until (waiting for the first item to regain selection) will make this system test more reliable.

    find_editor.send :arrow_up

    assert find_editor.open_prompt?, "Prompt should remain open after arrow up"

    prompt_items = all(".lexxy-prompt-menu__item")
    assert prompt_items[0]["aria-selected"], "First item should be selected after arrow up"
    refute prompt_items[1]["aria-selected"], "Second item should not be selected after arrow up"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.