Fix form attribute being discarded in rich_text_area_tag#740
Open
ophilbert wants to merge 1 commit intobasecamp:mainfrom
Open
Fix form attribute being discarded in rich_text_area_tag#740ophilbert wants to merge 1 commit intobasecamp:mainfrom
ophilbert wants to merge 1 commit intobasecamp:mainfrom
Conversation
:form attribute was removed from options. This attribute should pass through so we can associate lexxy editor with external form just like <input form="form_id">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lexxy_rich_textarea_tag was removing 'form' from html options.
This prevented using lexxy from outside a form like we can do with regular inputs:
<input form="myform">This change was made in actionText when they extracted ActionText::TrixEditor
This attribute should pass through so we can associate lexxy editor with external form.