Normalize file path returned by projectile-files-from-cmd#2001
Open
thomashilke wants to merge 1 commit intobbatsov:masterfrom
Open
Normalize file path returned by projectile-files-from-cmd#2001thomashilke wants to merge 1 commit intobbatsov:masterfrom
thomashilke wants to merge 1 commit intobbatsov:masterfrom
Conversation
On Windows, the file path harvested in the standard output of running `cmd` may use backslash as folder separator. Since the result of `projectile-files-from-cmd` are to be compared with the files from the current project in `projectile-replace`, both file path must be constructed/normalized in the same way for the comparison to be meaningful.
thomashilke
force-pushed
the
bugfix/normalize-file-path-from-files-with-string
branch
from
72eea8b to
09697ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, in the function
projectile-files-from-cmd, the file path harvested in the standard output of runningcmdmay use backslash as folder separator.Since the result of
projectile-files-from-cmdare to be compared with the files from the current project inprojectile-replace, both file path must be constructed/normalized in the same way for the comparison to be meaningful.Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)M-x checkdocwarningsThanks!