Track currently-selected chart name and chart mode in URL parameters #2191
+350
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1947 by adding URL parameters for the chart name and chart mode.
For example, the Balance Sheet with the Assets chart and the Icicle chart mode uses the balance_sheet/?chart_mode=icicle&chart=Assets parameters.
The chart mode is stored in a per-report localStorage (fava-last-active-chart-modes), so that switching to another page and back preserves the chart mode and associated parameters.
The priority order for determining the chart mode is: