Open
Conversation
…, now more gracefully fallback is provided to the user
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6319 +/- ##
==========================================
+ Coverage 68.77% 68.91% +0.13%
==========================================
Files 140 140
Lines 18619 18622 +3
Branches 3054 3054
==========================================
+ Hits 12806 12833 +27
+ Misses 5165 5140 -25
- Partials 648 649 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Situation mentioned bu user in the issue was very hard to copy and to understand, the issue was not in fetchers plugin but in
util.move() function and its fallback
First tries to copy file (cannot between disk (E: -> C: in user situation)
Then creating a copy tmp file and tries to move, I this moment between creating tmp file and moving it Foobar2000 wins race and block file. Move() tries to copy but can't now in section finally it tires to delete tmp file, which is blocked so cannot be deleted. My fix was to add try, except clause to catch error in finally section and raise FileSystemError with information that tmp file was not deleted.
Added test and also reproducing this situation locally on windows machine, added changeling entry, no documentation provided - It's small bug fix with classic try except clause
Fixes #6193 .
(...)
To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)