Add remove_missing option to convert plugin#6324
Open
javierbg wants to merge 7 commits intobeetbox:masterfrom
Open
Add remove_missing option to convert plugin#6324javierbg wants to merge 7 commits intobeetbox:masterfrom
javierbg wants to merge 7 commits intobeetbox:masterfrom
Conversation
Author
|
I see some failing checks on Windows, but it appears to be failing when invoking ffmpeg. I don't know if this is to be expected or not. |
Author
|
Ok, that seemed to do the trick. I made the mistake of copying the setup from another test case that must have been trying to test something about the path encodings. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6324 +/- ##
==========================================
+ Coverage 68.78% 68.83% +0.05%
==========================================
Files 140 140
Lines 18619 18644 +25
Branches 3054 3063 +9
==========================================
+ Hits 12807 12834 +27
+ Misses 5164 5161 -3
- Partials 648 649 +1
🚀 New features to boost your workflow:
|
Author
|
The same Windows error happens again. Can anyone help figure it out? I really don't understand why this would fail on Windows, when the "run_convert" call works in all other tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new configuration/option to the convert plugin.
The "remove_missing" option indicates that files in the convert destination directory not present in the library should be removed (asking for confirmation).
To Do
Beware that this is my first PR here, so I'm still unaware of common practices. I tried to follow the same principles that I saw in the
convert.pyfile, but I'm sure a lot of them will be outdated, feel free to suggest any changes.Also, I'm still not 100% sold on the config/option name. Let me know if you have a suggestion.