Draft
Conversation
- Test file format (valid and error cases) - Test regex pattern matching (_is_ignored) - Test _resolve_genres: ignored genres filtered - Test _resolve_genres: c14n ancestry walk blocked for ignored tags - Test _resolve_genres: without whitelist, oldest ancestor is kept - Test _resolve_genres: whithout whitelist, ignored oldest ancestor is removed
- Prevents wrong last.fm genres based on a per artist (or global) list of regex
patterns that should be ignored.
- Genre _ignoring_ happens in two places: Right after fetching the
last.fm genre and in _resolve_genres.
- As a fallback literal string matching can be used instead of
supplying a regex pattern
- Includes docs for the new feature.
and fix fallback types
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lastgenre_aliases #6474 +/- ##
=====================================================
+ Coverage 69.73% 69.99% +0.25%
=====================================================
Files 145 146 +1
Lines 18534 18661 +127
Branches 3023 3054 +31
=====================================================
+ Hits 12924 13061 +137
+ Misses 4976 4958 -18
- Partials 634 642 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The monolithic
_get_genremethod was broken down into the following private instance methods:_try_resolve_stage: Handles the canonicalization and logging of genres for a specific stage._fallback_stage: Provides the configured fallback genre._handle_existing_genres: Manages the initial check for pre-existing genres and thecleanup_existinglogic._get_track_genre_stage: Fetches and resolves track-level genres._get_album_genre_stage: Fetches and resolves album-level genres._get_artist_genre_stage: Fetches and resolves artist-level genres, including multi-valued album artists and "Various Artists" logic._get_va_genre_stage: specifically handles the plurality logic for "Various Artists" albums._get_original_fallback: Handles the "keep_existing" logic that attempts to use/canonicalize originally present genres if no new ones are found.To Do
DocumentationTests(_get_genre was already well covered and the signature of the method was kept)