Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
PR swap Discogs genre/style mapping so beets fields match Discogs meaning: Discogs genres are broad, Discogs styles are specific.
Changes:
- In Discogs plugin, read beets
genresfrom Discogsstyles, and beetsstylefrom Discogsgenres. - Update Discogs plugin tests to cover the swapped mapping.
- Update Discogs plugin docs + changelog entry for new mapping.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
beetsplug/discogs/__init__.py |
Swap Discogs genres/styles inputs when building AlbumInfo.style and AlbumInfo.genres. |
test/plugins/test_discogs.py |
Adjust release fixture + assertions for swapped mapping; rename one test. |
docs/plugins/discogs.rst |
Update append_style_genre + separator docs to describe new semantics. |
docs/changelog.rst |
Add changelog entry describing the Discogs mapping change. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6478 +/- ##
=======================================
Coverage 70.06% 70.06%
=======================================
Files 147 147
Lines 18562 18562
Branches 3026 3026
=======================================
Hits 13005 13005
Misses 4924 4924
Partials 633 633
🚀 New features to boost your workflow:
|
ddf7cce to
69af3cc
Compare
Member
|
those tiny copilot suggestions seem valid, other than that LGTM |
Member
Author
Member
69af3cc to
1de757f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

discogs: Swap genre and style field mappingFixes #6390
Fixes the semantic mismatch between Discogs' taxonomy and beets' fields. In Discogs, genres are broad (e.g. "Electronic") and styles are specific (e.g. "Techno"). Previously, beets stored them the wrong way around.
What changed
In
get_album_info, the source fields are swapped:genres(beets) now reads from Discogsstyles— the specific valuesstyle(beets) now reads from Discogsgenres— the broader valuesThe
append_style_genreconfig option retains its original intent: append broader style values togenreswhen enabled. Only the data source for each field changed, not the logic.