Added extra variable to loop to not run strlen on each iteration#1
Open
boginw wants to merge 1 commit intobeneater:masterfrom
Open
Added extra variable to loop to not run strlen on each iteration#1boginw wants to merge 1 commit intobeneater:masterfrom
boginw wants to merge 1 commit intobeneater:masterfrom
Conversation
boginw
changed the title
Owner
|
Good suggestion. I'll leave the PR open so it's easier for other people to see, but I'd prefer for the code in the repo to match what was in the video, so I won't merge. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
strlenin the condition of the for-loop in thesetup()function is run on every iteration. As always when dealing with strings, it can be slow. Therefore, I'd suggest running thestrlenonce and storing the result somewhere. This will lead to the same result, but faster.