refactor(notifications): unify notification UX into sidebar and add rich feed interactions#252
Draft
justjxke wants to merge 3 commits intobetter-auth:mainfrom
Draft
refactor(notifications): unify notification UX into sidebar and add rich feed interactions#252justjxke wants to merge 3 commits intobetter-auth:mainfrom
justjxke wants to merge 3 commits intobetter-auth:mainfrom
Conversation
|
@justjxke is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
c7efe67 to
ea40dbd
Compare
5 tasks
Contributor
Author
|
hmmm i should work on this again and improve the UI but idk if it's worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
/notificationspage flow with a single right-sidebar notifications experience.How
Tests
pnpm fmt:checkpnpm typecheckpnpm lint(existing repo warnings unchanged, no new errors)Draft note
This PR is intentionally Draft because it still contains demo/dummy notification data used for local development and UX validation.
Before merge, we should remove or fully gate dummy notification paths for production.
Notes
I'd heavily appreciate design feedback, what you want removed, added, changed ect. This took quite a while, most of it brainstorming on the design and interaction flow. There's definitely room for improvement.
Screenshots