fix: enable horizontal scroll for contribution chart on mobile#306
Open
AbhiVarde wants to merge 3 commits intobetter-auth:mainfrom
Open
fix: enable horizontal scroll for contribution chart on mobile#306AbhiVarde wants to merge 3 commits intobetter-auth:mainfrom
AbhiVarde wants to merge 3 commits intobetter-auth:mainfrom
Conversation
|
@AbhiVarde is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
27c934c to
ce41363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On mobile devices, the contribution chart was not horizontally scrollable,
causing months beyond May/June to be cut off and inaccessible.
Root Cause
Two issues were blocking the scroll:
overflow-hiddenon the grid column insidecontribution-chart.tsxwasclipping the scroll container, preventing it from calculating its true width
user-profile-content.tsxhad no overflowhandling, allowing content to bleed outside the rounded border
Solution
contribution-chart.tsx: Changedoverflow-hidden→min-w-0on thegrid column so the scroll container can expand to its natural width
user-profile-content.tsx: Addedoverflow-hiddento the chart wrappercard to cleanly clip content within the rounded border
Files Changed
apps/web/src/components/dashboard/contribution-chart.tsxapps/web/src/components/users/user-profile-content.tsxScreenshots