Fix comment action parity across discussions and reviews#318
Open
justjxke wants to merge 4 commits intobetter-auth:mainfrom
Open
Fix comment action parity across discussions and reviews#318justjxke wants to merge 4 commits intobetter-auth:mainfrom
justjxke wants to merge 4 commits intobetter-auth:mainfrom
Conversation
|
@justjxke is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
66fcf85 to
1bc6cc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Comment action behavior had drifted across issue, pull request, review, and discussion surfaces.
Discussion starter posts, discussion comments, and PR review comments were missing action menus that GitHub exposes, and top-level review bodies were treated differently from the nested review comments beneath them. That inconsistency meant users could edit, report, or reference some comment-like surfaces but not others, even when the underlying GitHub object supported the same workflow.
The follow-up problem was that the menu model itself was incomplete. Better Hub had no report-content handoff, no reference-in-new-issue flow, and several top-level author surfaces still used bespoke controls instead of the shared action menu. That made the UI harder to reason about and easier to regress whenever a new comment surface was added or updated.
How
This change makes comment actions capability-driven and applies the same shared menu system across the missing surfaces.
The first part of the branch:
The second part of the branch expands the shared action model:
Report contentas a confirmed handoff to GitHub's report-content flowReference in new issuewith a native Better Hub dialog seeded from the source body and permalinkowner/repoIssue body actions,Discussion actions, andReview actions, with matching edit labels likeEdit discussionandEdit reviewResult
After this branch:
Validation
I validated the branch with targeted automated checks:
bun test apps/web/src/lib/comment-actions.test.tsbun x oxlint apps/web/src/lib/comment-actions.ts apps/web/src/lib/comment-actions.test.ts apps/web/src/components/shared/comment-action-dialogs.tsx apps/web/src/components/pr/message-actions-menu.tsx apps/web/src/components/pr/collapsible-review-card.tsx apps/web/src/components/discussion/discussion-conversation.tsxbun x oxfmt --check apps/web/src/lib/comment-actions.ts apps/web/src/lib/comment-actions.test.ts apps/web/src/components/shared/comment-action-dialogs.tsx apps/web/src/components/pr/message-actions-menu.tsx apps/web/src/components/pr/collapsible-review-card.tsx apps/web/src/components/discussion/discussion-conversation.tsxI also smoke-tested the UI in the local app with Playwright against an authenticated session:
Issue body actionson issue#314Discussion actionson discussion#277Review actionson PR#130owner/repoNo real report submission or issue creation was completed during the browser checks.