Skip to content

feat: adding AccessionNumber to base tags#444

Open
caryn-geady wants to merge 2 commits into
mainfrom
caryn-geady/dev/add-base-tag
Open

feat: adding AccessionNumber to base tags#444
caryn-geady wants to merge 2 commits into
mainfrom
caryn-geady/dev/add-base-tag

Conversation

@caryn-geady

@caryn-geady caryn-geady commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Add AccessionNumber to the list of base tags recognized by MIT.

Summary by CodeRabbit

  • New Features
    • DICOM metadata extraction now automatically captures the AccessionNumber field, providing more complete metadata information in all extraction operations.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pixi.lock is excluded by !**/*.lock and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9a23ff8-641e-4210-bbef-98811713c7c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR adds the DICOM tag AccessionNumber to the standard metadata extraction list in ModalityMetadataExtractor, ensuring this field is always extracted and returned as part of the standard metadata when available.

Changes

DICOM metadata extraction

Layer / File(s) Summary
Add AccessionNumber to base extraction tags
src/imgtools/dicom/dicom_metadata/extractor_base.py
AccessionNumber is added to ModalityMetadataExtractor.base_tags, making it part of the standard extracted metadata set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding AccessionNumber to base tags in the DICOM metadata extractor.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch caryn-geady/dev/add-base-tag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.98%. Comparing base (ee330b5) to head (5bd86fc).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ee330b5) and HEAD (5bd86fc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ee330b5) HEAD (5bd86fc)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #444       +/-   ##
===========================================
- Coverage   54.85%   43.98%   -10.87%     
===========================================
  Files          66       66               
  Lines        4370     4370               
===========================================
- Hits         2397     1922      -475     
- Misses       1973     2448      +475     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant