Set current language via lang attribute, proper rtl support#6187
Merged
farhatahmad merged 1 commit intobigbluebutton:masterfrom Jan 29, 2026
Merged
Set current language via lang attribute, proper rtl support#6187farhatahmad merged 1 commit intobigbluebutton:masterfrom
farhatahmad merged 1 commit intobigbluebutton:masterfrom
Conversation
danimo
force-pushed
the
impr/accessibility
branch
2 times, most recently
from
6619c49 to
3d5aacf
Compare
This enables screen readers to pick the proper language. Right now some readers will always use english. Additionally, rtl support was broken. This is fixed by the this commit. In rtl languages, the interface will be flipped when the language is picked. It's not a separate commit because it started as a side effect for the lang attribute effort.
danimo
force-pushed
the
impr/accessibility
branch
from
3d5aacf to
d9aaef3
Compare
|
|
thumbs up! |
farhatahmad
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables screen readers to pick the proper language. Right now some readers will always use english.
Additionally, rtl support was broken. This is fixed by the this commit. In rtl languages, the interface will be flipped when the language is picked. It's not a separate commit because it started as a side effect for the lang attribute effort.