Skip to content

fix(accounts): correct typos in account type constants#1046

Merged
abouolia merged 1 commit intodevelopfrom
fix/account-type-typos
Mar 16, 2026
Merged

fix(accounts): correct typos in account type constants#1046
abouolia merged 1 commit intodevelopfrom
fix/account-type-typos

Conversation

@abouolia
Copy link
Copy Markdown
Contributor

Summary

  • Fix 'none-current-asset''non-current-asset' typo in ACCOUNT_TYPE constant (backend and frontend)
  • Fix 'non-ACCOUNT_PARENT_TYPE.CURRENT_ASSET''non-current-asset' copy-paste error in frontend ACCOUNT_PARENT_TYPE
  • Fix 'expene''expense' typo in ACCOUNT_ROOT_TYPE
  • Add database migration to update existing records with the corrected account type value

Changes

Backend:

  • packages/server/src/constants/accounts.ts - Fixed NON_CURRENT_ASSET value
  • packages/server/src/modules/Accounts/Accounts.constants.ts - Fixed NON_CURRENT_ASSET value
  • packages/server/src/database/tenant/migrations/20260316000000_fix_account_type_typos.ts - New migration to fix existing data

Frontend:

  • packages/webapp/src/constants/accountTypes.tsx - Fixed NON_CURRENT_ASSET and EXPENSE values

Test plan

  • Run database migration and verify existing records are updated
  • Create a new "Non-Current Asset" account and verify it uses correct type
  • Verify balance sheet reports still work correctly
  • Query database to confirm no records remain with account_type = 'none-current-asset'

Fixes #1041

🤖 Generated with Claude Code

- Fix 'none-current-asset' -> 'non-current-asset' in ACCOUNT_TYPE
- Fix 'non-ACCOUNT_PARENT_TYPE.CURRENT_ASSET' -> 'non-current-asset' copy-paste error
- Fix 'expene' -> 'expense' typo in ACCOUNT_ROOT_TYPE
- Add database migration to update existing records

Fixes #1041

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@abouolia abouolia marked this pull request as ready for review March 16, 2026 00:29
@abouolia abouolia merged commit cfbfc0b into develop Mar 16, 2026
2 checks passed
@abouolia abouolia deleted the fix/account-type-typos branch March 16, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typo in COA: none-current-asset should be non-current-asset

1 participant