Skip to content

Update translations#2847

Open
bc-svc-local wants to merge 1 commit intomasterfrom
LOCAL-1444-deliver-translations-2026-02-23-09-32-27
Open

Update translations#2847
bc-svc-local wants to merge 1 commit intomasterfrom
LOCAL-1444-deliver-translations-2026-02-23-09-32-27

Conversation

@bc-svc-local
Copy link
Collaborator

@bc-svc-local bc-svc-local commented Feb 23, 2026

This pull request was created automatically. Please check new translations, approve and deliver them.


Note

Low Risk
String-only translation updates; main risk is incorrect placeholders/wording causing confusing UI messages in affected locales.

Overview
Updates several packages/locale/src/translations/*.json locale files to localize previously-English strings.

This replaces the numeric validation error messages (custom_min_number_error, custom_max_number_error, custom_range_error) and updates Adyen multibanco mandate labels (reference, entity) across Danish, German, Spanish variants, French, Italian, Japanese, Dutch, Norwegian, and Swedish.

Written by Cursor Bugbot for commit d07f147. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

"custom_max_number_error": "{label} must be less than or equal to {max}",
"custom_range_error": "{label} must be between {min} and {max}",
"custom_min_number_error": "{label} debe ser mayor o igual a 0 {min}",
"custom_max_number_error": "{label} debe ser menor o igual a 100 {max}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded values corrupt Spanish LATAM error messages

High Severity

The custom_min_number_error and custom_max_number_error translations contain hardcoded example values (0 and 100) in addition to the {min} and {max} placeholders. At runtime, this produces garbled messages like "debe ser mayor o igual a 0 5" instead of "debe ser mayor o igual a 5". This affects all Spanish LATAM locales: es-419, es-AR, es-CL, es-CO, es-LA, es-MX, and es-PE. Compare with the correct es.json (Spain) which uses only the placeholder.

Additional Locations (2)

Fix in Cursor Fix in Web

"custom_max_number_error": "{label} must be less than or equal to {max}",
"custom_range_error": "{label} must be between {min} and {max}",
"custom_min_number_error": "{label}は 0 以上である必要があります{min}",
"custom_max_number_error": "{label}は 100 以下である必要があります{max}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded values corrupt Japanese error messages

High Severity

The custom_min_number_error and custom_max_number_error Japanese translations contain hardcoded example values (0 and 100) with the {min}/{max} placeholders appended at the end. At runtime, this produces broken messages like "Fieldは 0 以上である必要があります5" instead of "Fieldは 5 以上である必要があります". The placeholders need to replace the hardcoded numbers, not be appended after them.

Fix in Cursor Fix in Web

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good comment, cc @bc-yehor-kravchenko / @kristinapototska for review - see also the comment above this one

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this manually, and the correction will come automatically in the next pull request.
https://bigcommercecloud.atlassian.net/browse/LOCAL-3098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants