fix(payment): CHECKOUT-9796 Restore removal of fallback strategies from essential build#3165
Merged
animesh1987 merged 2 commits intomasterfrom Mar 8, 2026
Merged
fix(payment): CHECKOUT-9796 Restore removal of fallback strategies from essential build#3165animesh1987 merged 2 commits intomasterfrom
animesh1987 merged 2 commits intomasterfrom
Conversation
animesh1987
changed the title
animesh1987
changed the title
…om essential build
animesh1987
commented
Mar 5, 2026
scripts/webpack/get-next-version.js
Outdated
| // version because there is no new commit ahead of it. | ||
| if ( | ||
| process.env.WATCH || | ||
| process.env.NODE_ENV !== 'production' || |
Contributor
Author
There was a problem hiding this comment.
Had to do this, since it was creating a new build version for sdk which was causing hosted fields to not load while testing as a custom checkout.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
davidchin
approved these changes
Mar 5, 2026
davidchin
reviewed
Mar 5, 2026
| paymentIntegrationService, | ||
| paymentStrategyFactories, | ||
| // TODO: Replace once CHECKOUT-9450.lazy_load_payment_strategies experiment is rolled out | ||
| // process.env.ESSENTIAL_BUILD ? {} : paymentStrategyFactories, |
Contributor
There was a problem hiding this comment.
Maybe keep the TODO comment because we'll still need to do that step.
bc-peng
approved these changes
Mar 5, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
richapatel1510
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Restore
Rollout/Rollback
Testing
Note
Medium Risk
Changes how payment/customer/checkout-button strategies are registered and bundled (including essential-build behavior and optional lazy-strategy rollout), which could affect which strategies are available at runtime during initialization/finalization flows.
Overview
Restores essential-build behavior by excluding bundled checkout-button strategies when
process.env.ESSENTIAL_BUILDis set, and adds arollOutLazyPaymentStrategiesoption tocreateCheckoutServiceto limit v2 registries to only essential factories (always includingNO_PAYMENT_DATA_REQUIRED) and omit customer strategies when rolling out lazy loading.Simplifies v2 strategy registration by removing
toResolvableModulewrapping and deleting the experiment-based mismatch checking/logging path (matchExistingIntegrations) along withErrorLoggerplumbing from the payment/customer strategy action creators; unit tests are updated accordingly.Written by Cursor Bugbot for commit 37f9c4a. This will update automatically on new commits. Configure here.