Conversation
NSUserNotification and NSUserNotificationCenter were deprecated in macOS 11 and removed entirely in macOS 14 (Sonoma), breaking all notification delivery including the -sound option on modern systems. Migrates to the UserNotifications framework (UNUserNotificationCenter), which is the supported API from macOS 10.14 onwards. Raises the minimum deployment target from 10.10 to 10.14 accordingly. Changes: - Fix -sound: now uses UNNotificationSound defaultSound/soundNamed: - -group now uses UNNotificationRequest identifiers for deduplication - -remove and -list use async UNUserNotificationCenter equivalents - -contentImage uses UNNotificationAttachment (local files only) - -ignoreDnD uses interruptionLevel .timeSensitive on macOS 12+ - Notification permission is requested via requestAuthorizationWithOptions: - applicationWillFinishLaunching: sets delegate early to handle click-launched activations before applicationDidFinishLaunching: runs Dropped features (no public API equivalent in UNUserNotificationCenter): - -sender: bundle identifier spoofing via NSBundle swizzle no longer has any effect; emits a warning and continues - -appIcon: _identityImage was a private NSUserNotification API with no UNUserNotificationCenter equivalent; emits a warning and continues Bumps version to 3.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sound, see upstream contribution for detailed PR description julienXX#322