[Feat/#39] main page publishing 및 api 연동#45
Merged
hyeonjin6530 merged 27 commits intodevelopfrom Feb 24, 2025
Merged
Conversation
…eature/#39-main-page-publishing
daun-up
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
Check List
✅ Key Changes
< 퍼블리싱 >
< API 연동 >
+) 추가적인 기능 구현
📢 To Reviewers
급하게 하느라 한 브랜치에 와랄라 작업 진행했습니다!
api의 경우, type을 따로 정의하고 swagger에 나누어져 있는 파트 기준으로 파일을 만들어 data 받아오는 부분만 분리하여 작성하였습니다.
파일 마다 axios를 import 하고 토큰도 일단 test 토큰 정의하여 사용중이라서 나중에 custom axios 파일을 만들어서 리팩토링 진행하면 될 거 같습니다! (토큰 제외)
main에 있는 carousel에 들어갈 이미지를 cover로 할지 contain 중 어떤 것으로 하는 게 좋을까요?(일단은 contain으로 할 경우 빈공간이 생길 수 있어서 cover로 해두었습니다.)
📸 스크린샷
🔗 참고 자료