You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @Cengoni ,
Here I have open a PR for to show installed metaphlan db version with the metaphlan --version command if available. Please feel free to review/merge the code to master or let me know if anything needs to be changed here.
Hi @Cengoni ,
As discussed per our conversation, I have update the pull request to support multiple metaphlan DB + non-default metaphlan DB folder with the metaphlan --version command. Please let me know if anything needs to be changed here. I will follow up in slack as well.
Hi @sagun98,
Thank you for adding this feature, I slightly modified the criteria for detection of the database for consistency with the latest commit I made on master. Instead of checking the presence of the fasta file - which is now removed after installation - it checks for presence of bowtie2 indexes, which are required together with the pickle file to be present in order to be able to run MetaPhlAn.
I think this PR breaks the compatibility with Humann 3.9.
At least I get the following error from Humann 3.9 with MetaPhlAn 4.1.2 in the same environment/container. CRITICAL ERROR: Can not call software version for metaphlan
It runs with no problems using MetaPhlAn 4.1.1
Just wanted to note it somewhere in case someone runs into the same problem.
Best wishes
Simon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Cengoni ,
Here I have open a PR for to show installed metaphlan db version with the metaphlan --version command if available. Please feel free to review/merge the code to master or let me know if anything needs to be changed here.
I will follow up with you in slack as well.
Regards,
Sagun