Upstream implementation to SSSOM Curator#232
Merged
Conversation
cthoyt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR externalizes the code in Biomappings to SSSOM-Curator (https://github.com/cthoyt/sssom-curator), which generalizes a lot of the functionality of Biomappings and re-brands it as domain-agnostic. I haven't decided yet where to house this generalized functionality yet, so it lives in my personal account for the moment.
This PR doesn't affect the CLI nor the functions exposed from Biomappings, though, the last few updates have been moving towards a reusable object model for semantic mappings from ssson-pydantic, so some parts will lose backwards compatibility because of that. This will come with a minor version bump.
This was motivated by NFDI use cases, where people outside of the biomedical domain are more or less consistently put off by the nomenclature of software components/databases in the biopragmatics stack.