ELECTRON: Import correct cloud file when multiple exist#2599
Merged
d0sboots merged 1 commit intoMar 27, 2026
Conversation
d0sboots
reviewed
Mar 25, 2026
d0sboots
left a comment
Collaborator
There was a problem hiding this comment.
I'm fine with the TODOs, I don't want to expand the scope of this beyond what it already is.
antoinedube
pushed a commit
to antoinedube/bitburner-source
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When retrieving Steam cloud data, we always use the first file returned from
steamworksClient.cloud.listFiles. However, this API can return multiple files, and their order is not guaranteed.MRE:
steamworksClient.cloud.listFileson machine 2 now returns both "foo" and "bar" with no guaranteed order.The fix is to use the most recently persisted cloud file instead of the first file in that array.
Note:
steamworksClient.cloud.writeFilealways fails. This issue is tracked in BUGFIX: Electron app cannot sync new save file to Steam Cloud #2105. I'm holding off on that PR and wait for v3 release.This PR uses a new version of my fork of steamworks.js.