schnorrsig: Optimize negation in verification#1830
Closed
real-or-random wants to merge 1 commit intobitcoin-core:masterfrom
Closed
schnorrsig: Optimize negation in verification#1830real-or-random wants to merge 1 commit intobitcoin-core:masterfrom
real-or-random wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
This trades a scalar negation for a group (= field) negation. This is admittedly more for fun because the actual improvement is hardly noticeable, but since it's in signature verification, I couldn't resist. In fact, we could store the xonly pubkey as odd when we parse it, and save the negation entirely, but this adds complexity and I leave this to the next crazy contributor.
Contributor
Author
|
scalar_neg takes about 2 ns on my laptop. fe_neg is much faster. But damn, while I'm writing this I noticed that I overlooked the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trades a scalar negation for a group (= field) negation. This is admittedly more for fun because the actual improvement is hardly noticeable, but since it's in signature verification, I couldn't resist.
In fact, we could store the xonly pubkey as odd when we parse it, and save the negation entirely, but this adds complexity and I leave this to the next crazy contributor.