Fix V2 Rest book API return funding result error #205
Open
fshiori wants to merge 2 commits intobitfinexcom:masterfrom
Open
Fix V2 Rest book API return funding result error #205fshiori wants to merge 2 commits intobitfinexcom:masterfrom
fshiori wants to merge 2 commits intobitfinexcom:masterfrom
Conversation
3 tasks
|
@fshiori Really appreciate the PR, bump into the exact same problem here. |
harry830622
reviewed
Aug 8, 2020
| } | ||
|
|
||
| func IsFunding(symbol string) bool { | ||
| return strings.HasPrefix(symbol, "f") |
There was a problem hiding this comment.
Suggested change
| return strings.HasPrefix(symbol, "f") | |
| return strings.HasPrefix(symbol, FundingPrefix) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
rest book api return different sort by trading and funding,
and now the SDK only support trading.
Breaking changes:
None
New features:
None
Fixes:
PR status: