Skip to content

Add commented includeBuild configurations for debugging#2096

Merged
rfc2822 merged 1 commit intomainfrom
libs-composite-builds
Mar 25, 2026
Merged

Add commented includeBuild configurations for debugging#2096
rfc2822 merged 1 commit intomainfrom
libs-composite-builds

Conversation

@rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Mar 23, 2026

Purpose

This PR adds commented includeBuild configurations to assist with subproject debugging.

Tip

With this PR: If you want to work in davx5-ose and a subproject at the same time, you can just uncomment the respective lines from settings.gradle.kts.

Only make sure that you have checked out the subproject in the correct directory (like ../synctools so that synctools is on the same directory level as davx5-ose) and with the correct branch etc.

See https://cloud.bitfire.at/call/iuai87nn#message_54925

Short description

  • Added commented includeBuild configurations for easier subproject debugging.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 self-assigned this Mar 23, 2026
@rfc2822 rfc2822 added the chore codebase/CI maintenance, no production code change label Mar 23, 2026
@rfc2822 rfc2822 marked this pull request as ready for review March 23, 2026 17:29
@rfc2822 rfc2822 requested a review from ArnyminerZ March 23, 2026 17:29
@cketti
Copy link
Contributor

cketti commented Mar 23, 2026

We could use system/Gradle properties to control the behavior.

@rfc2822
Copy link
Member Author

rfc2822 commented Mar 23, 2026

We could use system/Gradle properties to control the behavior.

You mean to enable/disable it? I think it's more work during debugging to set a variable than to uncomment the lines. (If we accidentally commit the lines, the tests would fail anyway.)

But I'm open to further improvements. I just wanted to propose the change now because since I have used it, I don't want to go back or anyone else to wait again for jitpack builds 😀

@rfc2822 rfc2822 merged commit ad7f2fb into main Mar 25, 2026
5 of 6 checks passed
@rfc2822 rfc2822 deleted the libs-composite-builds branch March 25, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore codebase/CI maintenance, no production code change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants