Update install.sh - create default filter data directory#3
Update install.sh - create default filter data directory#3samuel-white wants to merge 2 commits intoblankhaus:mainfrom
Conversation
Great plugin, thanks. Following installation I received an error that the folder where filter data is stored didn't exist. Suggest adding mkdir to installation script - or add mkdir step to instructions.
There was a problem hiding this comment.
Hello @samuel-white, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where the filter data directory is not created during the plugin installation process. The author, samuel-white, suggests adding a mkdir command to the install.sh script to create the directory ~/printer_data/config/plugins/filter_monitor. This ensures that the directory exists, preventing errors after installation.
Highlights
- Bug fix: The pull request fixes a bug where the filter data directory is not created during installation.
- Installation improvement: The pull request improves the installation process by automatically creating the necessary directory.
Changelog
- install.sh
- Added a
mkdircommand to create the~/printer_data/config/plugins/filter_monitordirectory during installation. - The new
mkdircommand is inserted between the chmod commands and the echo command.
- Added a
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A folder's need,
In the script, we now plant,
No errors arise.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds a directory creation step to the install script, which addresses a reported issue where the filter data directory was missing after installation. This is a good improvement to enhance the user experience.
Merge Readiness
The code change is a small but important fix. I recommend merging this pull request after addressing the suggested improvement to ensure the directory creation is more robust. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Great plugin, thanks. Following installation I received an error that the folder where filter data is stored didn't exist. Suggest adding mkdir to installation script - or add mkdir step to instructions.