Draft
Conversation
godmodegalactus
requested changes
Jan 16, 2024
|
|
||
| ## Fanout size and retries configuration | ||
| FANOUT_SIZE=32 | ||
| FANOUT_SIZE=18 |
Collaborator
There was a problem hiding this comment.
Why did you reduce ?
| let mut last_finalized_slot: Slot = 0; | ||
| loop { | ||
| tokio::select! { | ||
| confirmed_block = confirmed_blocks_stream.next() => { |
Collaborator
There was a problem hiding this comment.
I feel the streams are not working well, the performance issues that I found was related to stream when I moved back to channel it is not working very well. May be thing that you can check on your side.
| .await; | ||
|
|
||
| log::trace!("glb {blockhash} {slot} {block_height}"); | ||
| info!("glb {blockhash} {slot} {block_height}"); |
Collaborator
There was a problem hiding this comment.
why info no need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: THIS IS A DRAFT
what's missing: