Draft
Conversation
ghost
force-pushed
the
2_0_16
branch
6 times, most recently
from
c60f0b4 to
23ba2a0
Compare
Collaborator
|
how is this related to Pratiks crate solana-lite-account-manager ? |
|
|
||
| #[async_trait] | ||
| impl AccountStorageInterface for AccountsDb { | ||
| async fn update_account(&self, account_data: AccountData, _commitment: Commitment) -> bool { |
Collaborator
There was a problem hiding this comment.
note: we actually do not want to have and support commitments other than PROCESSED as this will push complexity of buffering and slot commitment handling to yellowstone-grpc
| } | ||
| } | ||
|
|
||
| async fn process_slot_data(&self, slot: Slot, commitment: Commitment) -> Vec<AccountData> { |
Collaborator
There was a problem hiding this comment.
pratik promised to do a proper tested implementation in solana-lite-account-manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires 2_0_16 to be landed first