Remove unneeded ID number, we just need the manufacturer name for mysql inserts#648
Open
curtishall wants to merge 1 commit intomasterfrom
Open
Remove unneeded ID number, we just need the manufacturer name for mysql inserts#648curtishall wants to merge 1 commit intomasterfrom
curtishall wants to merge 1 commit intomasterfrom
Conversation
Remove unneeded ID number, we just need the manufacturer name
andrey-utkin
reviewed
Jan 4, 2024
| @@ -1364,7 +1364,7 @@ public static function getList($manufacturer) | |||
| // print_r($data); | |||
|
|
|||
| foreach($data['records'] as $camera) { | |||
Contributor
There was a problem hiding this comment.
This loop iterates over all known camera models for the searched manufacturer.
We can't use rawurlencode($manufacturer) as the array index because all the entries but the last one will be overwritten.
Contributor
|
I have doubt that the fix proposed is going to work. I'd need some more time to understand how the key strings of Devices.model DB field is limited to 30 characters (see CREATE TABLE `Devices` (
...
`model` varchar(30) DEFAULT NULL, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded ID number, we just need the manufacturer name
Fixes #647
We were pulling the following json via API...however were added the Manufactuer AND the ID (for unknown reasons) which was being inserted into the database like 'IP Camera - recpSlTQIiaJez87D' which should never have happened and the model insert into mysql was too long anyway causing an ajax error.