Skip to content

Implement a zero copy tzdb provider#662

Merged
nekevss merged 6 commits intomainfrom
impl-zero-tzdb-provider
Feb 3, 2026
Merged

Implement a zero copy tzdb provider#662
nekevss merged 6 commits intomainfrom
impl-zero-tzdb-provider

Conversation

@nekevss
Copy link
Member

@nekevss nekevss commented Dec 30, 2025

This PR implements the bulk of the logic from the initial PR to create a zero copy tzdb provider.

A couple notes:

  • Some of the logic is duplicated from the CompiledTzdbProvider and FsTzdbProvider (although, there is hopefully room to consolidate this in future PRs)
  • This has been run locally on Boa and there was no major regressions with maybe one or two additional failures in the intl402 suite.

@nekevss nekevss requested review from a team and Manishearth December 30, 2025 03:22
@nekevss nekevss mentioned this pull request Dec 30, 2025
Merged
@nekevss nekevss requested a review from jedel1043 January 6, 2026 04:39
jasonwilliams
jasonwilliams approved these changes Feb 3, 2026
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss merged commit 4e0afcc into main Feb 3, 2026
8 checks passed
@nekevss nekevss deleted the impl-zero-tzdb-provider branch February 3, 2026 20:43
nekevss added a commit that referenced this pull request Feb 4, 2026
@nekevss
Fix Sao Paulo bug in zoneinfo_rs (#663)
d60aac5 
Dependent on #662.

This PR fixes a bug in `zoneinfo_rs` that was causing a failures on Sao
Paulo time zone tests.

Primary bug fixes are in
[feb61e1](feb61e1).

The other three commits are adding related to adding tests or rebuilding
the compiled data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth

@jedel1043 jedel1043 Awaiting requested review from jedel1043

@hansl hansl Awaiting requested review from hansl

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@Razican Razican Awaiting requested review from Razican

@raskad raskad Awaiting requested review from raskad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nekevss @jasonwilliams