Open
Conversation
* In PDF, a page’s /Resources override inherited ones; inheritance only supplies missing entries. So the page dict must win and the parent should only fill gaps. Flipping the merge (child ← parent) with a block that prefers old (the child’s existing values) implements exactly that rule. * Using the page dict as the merge target also avoids polluting inheritance_hash (which may be shared across siblings), reducing chances of recursive structure growth that leads to cycles and SystemStackError * The merge block is enhanced with early exits for identical objects and identical indirects (and treat reference wrappers as leaves)
martal1990
approved these changes
Sep 8, 2025
|
I have tried this, and it works. Thank you for the PR. Now I need both this PR and #250. I guess I have to try to find a way around before these PRs are merged and released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242