Add tests for checking boundary options in 1D convolution#612
Open
meshtag wants to merge 1 commit intoboostorg:developfrom
Open
Add tests for checking boundary options in 1D convolution#612meshtag wants to merge 1 commit intoboostorg:developfrom
meshtag wants to merge 1 commit intoboostorg:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #612 +/- ##
===========================================
+ Coverage 78.76% 79.28% +0.51%
===========================================
Files 117 117
Lines 5030 5030
===========================================
+ Hits 3962 3988 +26
+ Misses 1068 1042 -26 🚀 New features to boost your workflow:
|
simmplecoder
requested changes
May 30, 2021
Contributor
|
I had a look at the error GA are giving. It seems like the compiler uses C++11 mode but standard library doesn't ... It seems more like C++20 is being used for standard library. I wanted to have a look at the CI script for GA, but couldn't find it. My guess off the bat would be that problem lies in the |
3 tasks
Member
|
@meshtag Could you tell what is the status of this PR? Is this going to be picked up or drop it and close it? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request intends to add unit tests for verifying boundary manipulation in
1D convolution. Since these are tests(used for provingcorrectnessof implementation), I have favoured readability/simplicity over performance(for example : All tests written insideconvolve.cppdo not require a separate image to be created after row convolution. However, doing so greatly simplifies its structure and saves the reader from unnecessary trouble of understanding a complex manipulation).Flag
boundary_option::extend_paddedconvolves the image assuming a padding around it. This leads to some unknown values of boundary pixels. For testing rest of the pixels(whose values can be predicted), I have deliberately made unknown values inoriginal_output_imageandexpected_imageequal. I have highlighted this with comments in the code.Tasklist