Update template.ts to include Layout schema#15
Update template.ts to include Layout schema#15abhinavrastogi-harness wants to merge 5 commits intobradrydzewski:masterfrom
Conversation
Adds an optional Layout schema for controlling the UI ordering and grouping of inputs
schema/ui.ts
Outdated
| /** | ||
| * Options to populate the dropdown if the `component` is "select" | ||
| */ | ||
| options?: string[] |
There was a problem hiding this comment.
options is also available in input interface outside of ui
maybe should be kept at only one place?
There was a problem hiding this comment.
@shaurya-harness i've added this here because the UI code supports it here today. Ideally yes, we should remove this and only use the options configured outside the ui object.
| @@ -1,3 +1,5 @@ | |||
| import { UiConfig } from "./ui"; | |||
|
|
|||
There was a problem hiding this comment.
enum and options are duplicated
also shall we standardize enum / list / options - all seem to be doing the same thing
|
sorry for the delayed response on this one. can you guys update this to match the naming conventions for consistency purposes: |
4 participants
Adds an optional Layout schema for controlling the UI ordering and grouping of inputs