Skip to content

Rohan changes#6

Open
thisrohangupta wants to merge 11 commits intobradrydzewski:masterfrom
thisrohangupta:rohan-changes
Open

Rohan changes#6
thisrohangupta wants to merge 11 commits intobradrydzewski:masterfrom
thisrohangupta:rohan-changes

Conversation

@thisrohangupta
Copy link
Contributor

No description provided.

user: 1000
memory: 10mb
cpu: 0.25
args:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisrohangupta How do we want to take care of downloading of artifacts and feeding into this serverless.yaml ?
Right now , its done inside serverless package step by us before executing serverless package command , but that's not a good design here. Each plugin should have well defined responsibilities and downloading of artifacts should not be the responsibility of serverless package plugin. Customers could always script the downloading of artifacts , and then scripting the part of putting that artifact inside serverless.yml. But the question is do we want customers to script it ? Should we have a seperate plugin for handling that ? I am not sure if this is urgent , but we should think about handling artifacts in our services via an independent plugin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use custom expressions inside serverless manifest to feed artifact like "<+artifact.image>" and "<+artifact.path>". If we have an independent plugin for downloading artifacts, we could generalize some expressions for the path where the artifact downloads and use that expressions instead , which could be used irrespective of the swimlane

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-bhuwalka we will run arifact collection as an independent plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants