Also calling watchFile on collect, so that initially cached files get watched.#327
Open
wnr wants to merge 1 commit intobrowserify:masterfrom
Open
Also calling watchFile on collect, so that initially cached files get watched.#327wnr wants to merge 1 commit intobrowserify:masterfrom
wnr wants to merge 1 commit intobrowserify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #306.
Calling
watchFileincollectshould not be a problem because 1)watchFileis smart enough to not add a file watcher if the given file is already watched and 2)collectis not executed often enough to impose a problem for the extra basic operations.I noticed no performance difference watching my projects, and the test suite is running as fast as before:
before:
npm test 5.63s user 0.88s system 25% cpu 25.075 totalafter:
npm test 5.60s user 0.87s system 25% cpu 25.032 total